Merged
Conversation
When shell v2 is enabled then the shell output is sent in packets that allow stdout, stderr and the exit status to be in separate channels. This updates the shell_command trait method so it can accept optionally separate stdout/stderr `dyn Write`s and return an optional u8 exit status. If no stderr `dyn Write` is given then stdout + stderr will be merged into the single stdout `dyn Write` Fixes: cocool97#171
rib
commented
Jan 13, 2026
| break; | ||
| } | ||
| output.write_all(&message.into_payload())?; | ||
| // should this just write for ::Write messages? |
Contributor
Author
There was a problem hiding this comment.
Since I'm not familiar with when this message transport is used, I wasn't entirely that I was updating this correctly
Contributor
Author
|
Btw, thanks for taking a look over this PR. Your follow up changes all look good to me. It would be great if you'd be able land this and make a release if possible. I'm currently depending on this branch in order to write / run tests for a jni binding generator for Android and currently need to wait for a release before I can publish to crates.io |
Owner
|
I'll create a new breaking release soon, and this PR will be included. I need to finish/merge the last waiting PR and it will follow :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When shell v2 is enabled then the shell output is sent in packets that allow stdout, stderr and the exit status to be in separate channels.
This updates the shell_command trait method so it can accept optionally separate stdout/stderr
dyn Writes and return an optional u8 exit status.If no stderr
dyn Writeis given then stdout + stderr will be merged into the single stdoutdyn WriteFixes: #171