Skip to content

Implement std::error::Error for XMLError#10

Merged
cocool97 merged 1 commit intococool97:masterfrom
cafce25:add-error-trait
Mar 19, 2023
Merged

Implement std::error::Error for XMLError#10
cocool97 merged 1 commit intococool97:masterfrom
cafce25:add-error-trait

Conversation

@cafce25
Copy link
Copy Markdown
Contributor

@cafce25 cafce25 commented Mar 19, 2023

Also implements the required Display trait by just using the existing Debug implementation.
Resolves #9

Copy link
Copy Markdown
Owner

@cocool97 cocool97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for the PR ;)

@cocool97 cocool97 merged commit f03dc3a into cocool97:master Mar 19, 2023
@yegor256
Copy link
Copy Markdown

@cafce25 @cocool97 partially motivated by https://stackoverflow.com/questions/75779835 Looking forward to a new release of the library, with this PR on board.

@cocool97
Copy link
Copy Markdown
Owner

Hey !
Thanks for your comment, you can bump your xml_builder version to 0.5.2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XmlError type should implement the Error trait

3 participants