Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jul 30, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

This PR solves 2 issues:

  1. In http://localhost/api/competitions/ , emails of users were leaked.
  2. In http://localhost/api/participants/ , no participants will be shown unless this is accessed from the website and not from /api/participants

Competition users emails:
Screenshot 2023-07-30 at 8 16 51 PM

Tested:

  • users emails are not leaked
  • participants are now shown in /api/participants
  • approve and revoke functionality works
  • sending email to participants works

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah changed the title don't show user's email in collaborators API Security - Competitions and Participants Jul 30, 2023
@ihsaan-ullah ihsaan-ullah requested a review from dtuantran August 3, 2023 14:47
@Didayolo Didayolo merged commit 662ba1b into develop Aug 9, 2023
@Didayolo Didayolo deleted the api_security_competition_collaborators branch August 9, 2023 10:33
@Didayolo Didayolo mentioned this pull request Aug 9, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants