Phase dates - do not use same dates for one phase end and next phase start

[ihsaan-ullah]

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now in both V1 and V2 bundles, Phase 1 end and Phase 2 start dates cannot be same

What will happen:

1. V1 if a phase has no end date and this phase is not the last phase, use the next phase (start date - 1) as its end date
2. V2: check if a phase is not the first phase, and its start date and previous phase end date are same, then raise error

V2 error screenshot

Issues this PR resolves

• Problem with phases dates (v1 bundle?) #1027

Checklist

• Code review by me
• Hand tested by me
• I'm proud of my work
• Code review by reviewer
• Hand tested by reviewer
• CircleCi tests are passing
• Ready to merge

[Didayolo]

@ihsaan-ullah Thank you for the PR.

Phase 1 end and Phase 2 start dates cannot be same

But then how to have the Phase 2 starting exactly when the Phase 1 is over? If P1 ends January 5, and P2 starts January 6, will the phase change operates at midnight between January 5 and 6?

[ihsaan-ullah]

@ihsaan-ullah Thank you for the PR.

Phase 1 end and Phase 2 start dates cannot be same

But then how to have the Phase 2 starting exactly when the Phase 1 is over? If P1 ends January 5, and P2 starts January 6, will the phase change operates at midnight between January 5 and 6?

Yes, When on server date changes to 6 January (i.e. after 23:59:50 on January 5), Phase 1 will end and phase 2 will start

[Didayolo]

OK, I'll check that this is not breaking old bundles and on-going benchmarks.