Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

When a user's public Queue is updated to private, remove it from all competitions which do not belong to this user.

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Aug 9, 2023

Steps to test:

  • Make a queue public
  • Another user add the queue to its benchmark as the queue is public
  • Make the queue private
  • The queue should be back to default in the benchmark

@Didayolo
Copy link
Member

Didayolo commented Aug 9, 2023

@ihsaan-ullah

Strange behavior observed:

  • User 1 make a queue public
  • User 2 uses it in a bechmark
  • User 1 make the queue private
  • Now the queue is removed from User 2 benchmark (back to default, the expected behavior). HOWEVER, User 2 can select again the queue and save the change. It is as if, once a queue is public, it can also be found to use it in any benchmark.

Another test, no problematic behavior:

  • User 1 creates a private queue
  • User 2 cannot find it in the editor (excepted behavior)

@ihsaan-ullah
Copy link
Collaborator Author

@ihsaan-ullah

Strange behavior observed:

  • User 1 make a queue public
  • User 2 uses it in a bechmark
  • User 1 make the queue private
  • Now the queue is removed from User 2 benchmark (back to default, the expected behavior). HOWEVER, User 2 can select again the queue and save the change. It is as if, once a queue is public, it can also be found to use it in any benchmark.

This is very strange. Checking this

@ihsaan-ullah
Copy link
Collaborator Author

@Didayolo with latest push that issue should be gone

@Didayolo
Copy link
Member

Interesting, I'll test this asap

@Didayolo Didayolo self-assigned this Aug 10, 2023
@Didayolo Didayolo merged commit 3da317c into develop Aug 10, 2023
@Didayolo Didayolo deleted the queue_make_private branch August 10, 2023 14:55
@Didayolo Didayolo mentioned this pull request Aug 10, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants