Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Aug 12, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

There was no edit task functionality in resource area. Now users can edit a task

Blue edit button in front of each task
Screenshot 2023-08-12 at 5 08 04 PM

On edit button, edit task modal is opened where user can make changes and update the task

Screenshot 2023-08-12 at 5 15 36 PM Screenshot 2023-08-12 at 5 15 41 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Thank you for the PR, it looks great. I'll test it when I have some time.

@ihsaan-ullah
Copy link
Collaborator Author

ihsaan-ullah commented Aug 14, 2023

@Didayolo Please don't merge this one yet. We need to discuss some stuff and it can possibly change this PR. I will create a detailed Issue about some discussion with Isabelle.

Edit: Discussion in the issue below:

@Didayolo
Copy link
Member

I merge this for now because it is useful, even if we want to keep an eye on the discussion and maybe restrict this feature in the future.

@Didayolo Didayolo merged commit f5f54fd into develop Aug 24, 2023
@Didayolo Didayolo deleted the edit_task branch August 24, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants