Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Aug 19, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

We had the following problems:

  1. HTML and markdown were not rendered when mixed
  2. Latex was not rendered.

Both of these are solved in this PR

What is done:

Rendeding of markdown-html-latex is fixed in:

  1. Competition pages
Screenshot 2023-08-19 at 1 37 44 PM
  1. Competition page view in the editor
Screenshot 2023-08-19 at 1 37 25 PM
  1. Phase description
Screenshot 2023-08-19 at 1 39 11 PM
  1. competition registration terms modal
Screenshot 2023-08-19 at 1 37 03 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

…tition pages view in editor, registration model, phase description
This was linked to issues Aug 19, 2023
@ihsaan-ullah ihsaan-ullah changed the title HTML - Markdown - Latex HTML - Markdown - Latex : Rendering Fixed Aug 19, 2023
@Didayolo
Copy link
Member

Very nice fix / addition. Thank you for your work, as always.

@Didayolo Didayolo merged commit 4abb922 into develop Aug 21, 2023
@Didayolo Didayolo deleted the latex branch August 21, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't mix Markdown and HTML LaTeX formulas in documentation pages

3 participants