Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Aug 20, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now In server status page, submission size is displayed
Screenshot 2023-08-20 at 1 55 17 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

@ihsaan-ullah

Why did you need to create a new function format_file_size(self, file_size) ?

Isn't this already defined in other places of the code (typically to give the size of submissions in the submissions tab) ?

@ihsaan-ullah
Copy link
Collaborator Author

@ihsaan-ullah

Why did you need to create a new function format_file_size(self, file_size) ?

Isn't this already defined in other places of the code (typically to give the size of submissions in the submissions tab) ?

this is a bit different in a way that there is no javascript code involved. the file size comes from the backend. In other places it is computed on the frontend which I think should be changed too to make everything synchronized

@Didayolo Didayolo merged commit 94a29e9 into develop Aug 21, 2023
@Didayolo Didayolo deleted the server_status_submission_size branch August 21, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants