Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Aug 21, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now in server status page there is an option to show child submissions. By default they are hidden

Default : show only parent (checkbox unchecked)
Screenshot 2023-08-21 at 3 47 08 PM

show parent and children (checkbox checked)
Screenshot 2023-08-21 at 3 47 17 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Remarks

  • There is a typo "chilld" --> "child".

  • We should add a question mark (?) next to "Show child submission" to give an explanation: child jobs are created when there are multiple tasks.

  • There is a conflict to resolve with views.py. It is normal, it is because I have merged the other PR about this interface.

@ihsaan-ullah
Copy link
Collaborator Author

Question mark for explanation
Screenshot 2023-08-21 at 4 01 00 PM

with parent id when checked show child submissions
Screenshot 2023-08-21 at 4 01 39 PM

without parent id when no children are shown
Screenshot 2023-08-21 at 4 01 42 PM

@ihsaan-ullah
Copy link
Collaborator Author

Resolved the conflicts

@Didayolo Didayolo merged commit f384b36 into develop Aug 21, 2023
@Didayolo Didayolo deleted the server_status_hide_child_submissions branch August 21, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants