Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Sep 1, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now users can see a warning message when submitting an empty display name

Screenshot 2023-09-01 at 3 39 44 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Sep 1, 2023 that may be closed by this pull request
@Didayolo
Copy link
Member

Didayolo commented Sep 2, 2023

This is a good start. However, users should be able to submit an empty display name. By default this field is empty. When it is empty, the username is used everywhere as the display name.

@ihsaan-ullah
Copy link
Collaborator Author

This is a good start. However, users should be able to submit an empty display name. By default this field is empty. When it is empty, the username is used everywhere as the display name.

now display name is not required BUT many users can use same display name

@Didayolo
Copy link
Member

Didayolo commented Sep 2, 2023

Nice. It is working fine.

@Didayolo Didayolo merged commit 4793354 into develop Sep 2, 2023
@Didayolo Didayolo deleted the display_name branch September 2, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display name already exists - bug with editing profile

3 participants