Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Sep 22, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now you can see report icon in the competition card in home page and public page
Screenshot 2023-09-22 at 7 40 30 PM
Screenshot 2023-09-22 at 7 27 47 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Sep 22, 2023 that may be closed by this pull request
@Didayolo
Copy link
Member

Excellent 👏

@Didayolo
Copy link
Member

When I remove the report, the logo is removed in the main page but not in the "public benchmarks" page, even if I hard refresh the page:

Capture d’écran 2023-09-22 à 17 53 20 Capture d’écran 2023-09-22 à 17 53 15

Not sure if its a cache problem or really related to the code

@Didayolo
Copy link
Member

I think it is related to cache because it is gone when I use another browser

@ihsaan-ullah
Copy link
Collaborator Author

When I remove the report, the logo is removed in the main page but not in the "public benchmarks" page, even if I hard refresh the page:

Capture d’écran 2023-09-22 à 17 53 20 Capture d’écran 2023-09-22 à 17 53 15
Not sure if its a cache problem or really related to the code

Can you also change the name to see if this is cache problem

@Didayolo Didayolo merged commit b728d06 into develop Sep 22, 2023
@Didayolo Didayolo deleted the competition_report branch September 22, 2023 15:58
@Didayolo
Copy link
Member

Indeed the name is not reflected either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display competition report in competition listing

3 participants