Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jan 3, 2024

Analytics snapshot date PR from Tristan Linked to: #1260

Description

This is a quick addition to the monitoring tool feature.

It adds the last snapshot date in the analytics view

Issues this PR resolves

It is a sub task of #713

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah
Copy link
Collaborator Author

@OhMaley

While testing this PR locally, I followed the instructions here to create a snapshot manually.

The snapshot is created but the time is not correct. I created at 8:23 PM GMT+5 but it shows 5PM GMT+5

Screenshot 2024-01-04 at 8 24 33 PM

@bbearce
Copy link
Collaborator

bbearce commented Jan 11, 2024

Tested locally and this is what I saw:

  • deployed develop and PR
  • uploaded comp and submission
  • kicked off storage analytics feature snap shot (no data for first one)
  • changed my computer's date to the 14th around 1am EST, more precisely 2024-01-14 06:36:44.954147+00 UTC from database. This should be 00:36 on the 14th EST. I'm guessing this gets "rounded up" by the UI.
  • re-ran the snap shot
  • the storage UI shows:
    image

"Last snaphost date: January 13, 2024 at 7:00 PM EST". It is my belief that somehow the 06:36 is being converted to 00:36am on the 14th or 1am. This might be an attempt to convert from UTC to EST. That suggests we should see 1am on the 14th on the UI. We however see 7pm the day before. So back up 6 hours and you get 7pm the day before which is the 13th.

I can demo a test of this and we can clear the data and check today in a couple hours...I think something is off.

@ihsaan-ullah
Copy link
Collaborator Author

@bbearce i will test this one more time locally and then will merge it

@ihsaan-ullah
Copy link
Collaborator Author

Tested locally, now the date shown is the correct one.

@ihsaan-ullah ihsaan-ullah merged commit 1a12fb4 into develop Jan 16, 2024
@ihsaan-ullah ihsaan-ullah deleted the analytics_snapshot_date branch January 16, 2024 07:01
@ihsaan-ullah ihsaan-ullah mentioned this pull request Jan 25, 2024
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants