Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jan 28, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Previously, when a task was disconnected from a competition but it was used in a submission: Rerunning such submission would result in a submission stuck in submitted status.

Now, when task/tasks are deleted, a warning message is shown to the user:
Screenshot 2024-01-28 at 4 12 46 PM
Screenshot 2024-01-28 at 4 13 25 PM

If a user tries to rerun submission with its task deleted, the following error message is shown:
Screenshot 2024-01-28 at 4 02 12 PM

Issues this PR resolves

A checklist for hand testing

For single-task phase

  • Create a competition with one task A per phase,
  • upload a submission and wait for its success,
  • add a new task B in resource interface
  • remove task A from phase
  • connect task B to this phase
  • delete task A from resource interface
  • rerun the submission and check if you get an error

For multi-task phase

  • repeat the above but make sure to create multi-task phase

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Feb 8, 2024

Nice job!

@Didayolo Didayolo merged commit b22c8f9 into develop Feb 8, 2024
@Didayolo Didayolo deleted the rerun_submission branch February 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants