Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Feb 7, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

1. In files tab if you are not loggedin, you will see a login message instead of an empty table

Screenshot 2024-02-07 at 3 13 24 PM

2. When loggedin, only competition admins can see available column

Admin view:
Screenshot 2024-02-07 at 3 13 08 PM

Participant view:
Screenshot 2024-02-07 at 3 13 37 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Feb 7, 2024 that may be closed by this pull request
2 tasks
@Didayolo
Copy link
Member

Didayolo commented Feb 9, 2024

@ihsaan-ullah

In your example, are the two screenshots from the same competition setting? Shouldn't the participant view include the starting kit and public data, as they are marked as available?

@ihsaan-ullah
Copy link
Collaborator Author

I am not sure if this was same competition. If you find this issue, this is not coming from this PR but we should solve it in another PR

@Didayolo
Copy link
Member

Didayolo commented Feb 9, 2024

Tested and approved!

@Didayolo Didayolo merged commit acf0125 into develop Feb 9, 2024
@Didayolo Didayolo deleted the files_tab branch February 9, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files tab issues

3 participants