Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Feb 7, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

We had two problems:

  1. When you delete a rerun submission, its original submission is also deleted
  2. When you delete original submission, its rerun submissions are also deleted.

NOW this PR fixes this problem i.e. do not delete original submission when a reun is deleted, similarly do not delete rerun submissions when original is deleted

Issues this PR resolves

A checklist for hand testing

  • upload a submission
  • rerun this submission (it will create a new submission)
  • delete the rerun submission and check that the original submission is NOT deleted
  • rerun the original submission again multiple times
  • delete the original submission and check that the rerun submission are NOT deleted

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

… do not delete rerun submission when original is deleted
@ihsaan-ullah ihsaan-ullah linked an issue Feb 7, 2024 that may be closed by this pull request
@Didayolo Didayolo merged commit 4ff7b40 into develop Feb 7, 2024
@Didayolo Didayolo deleted the submission_rerun_delete_parent branch February 7, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete submission problem

3 participants