Submission remove from leaderboard - Empty error

[ihsaan-ullah]

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

There was an empty error shown when someone wanted to remove a submission from leaderboard. Now an error message is displayed along with correction in the logic.

Issues this PR resolves

• Remove submission from leaderboad #1125
• Empty error message on trying to add another user's submission to leaderboard #1325

Checklist

• Code review by me
• Hand tested by me
• I'm proud of my work
• Code review by reviewer
• Hand tested by reviewer
• CircleCi tests are passing
• Ready to merge

[Didayolo]

Good job. It is very nice that you are adding comments, cleaning the form of the code and adding tests. Very good coding practices.

[Didayolo]

@ihsaan-ullah

It seems that I still have an error message when trying to add a submission to leaderboard when "Force last" is enabled:

---

When removing a submission, it depends:

• As an organizer / admin, I get the new error message ("You are not allowed [...]")
• As a simple participant, I get no error message

[ihsaan-ullah]

@ihsaan-ullah

It seems that I still have an error message when trying to add a submission to leaderboard when "Force last" is enabled:

When removing a submission, it depends:

• As an organizer / admin, I get the new error message ("You are not allowed [...]")
• As a simple participant, I get no error message

I will check this, i did not know that a simple participant can also do this. I tested it in the admin interface only

[ihsaan-ullah]

@Didayolo now it should be ok

[Didayolo]

Perfect