Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Feb 18, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Previously, all submissions of a phase were migrated to a new phase in the auto-migration.

NOW, only leaderboard submissions will be migrated

Issues this PR resolves

Test

  • Test it on test server (not tested locally)

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

I think it makes sense that the tests are failing. I guess the tests need to be adapted to match this change.

@ihsaan-ullah ihsaan-ullah linked an issue Feb 20, 2024 that may be closed by this pull request
5 tasks
@Didayolo Didayolo self-assigned this Feb 22, 2024
@Didayolo Didayolo merged commit bade1eb into develop Apr 16, 2024
@Didayolo Didayolo deleted the auto_migration branch April 16, 2024 15:46
@Didayolo
Copy link
Member

@ihsaan-ullah

I encountered a problem while testing this on the test server.

Here is the test competition:
https://codabench-test.lri.fr/competitions/143

Here is what I did:

  • Make several submissions in development phase from 2 users ("pavao" and "testos")
  • Have only 2 submissions on the leaderboard (1 for each user)
  • Select "auto-migration" option, and wait for the final phase to start

When the final phase started, the two submissions got run, so the change worked (only leaderboard submissions got run).

In the logs, I can find the scores and everything, so the submissions worked well:

Capture d’écran 2024-04-19 à 13 48 59

However, on the final phase leaderboard, the scores are N/A and the detailed results lead to 404 error:

Capture d’écran 2024-04-19 à 13 49 26

@ihsaan-ullah
Copy link
Collaborator Author

I think this problem is not related to the change I made because we have never tested auto migration. Or maybe you have tested auto migration before?

I am not sure but I think someone has reported this before

@Didayolo
Copy link
Member

OK, I had the impression it worked before but I'm not sure. I'll open another issue about it.

@Didayolo
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems with re-running submissions

3 participants