Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Apr 1, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now organizers can configure detailed results from competition setting. Organizers can choose to do the following:

Screenshot 2024-04-02 at 1 04 56 AM
  • Enable/disable detailed results
  • Show detailed result in submission panel
Screenshot 2024-04-02 at 1 06 13 AM - Show detailed result in leaderboard Screenshot 2024-04-02 at 1 06 46 AM

Settings can be controlled from yaml file too:
Screenshot 2024-04-02 at 1 07 23 AM

Documentation is updated here:
https://github.com/codalab/codabench/wiki/Yaml-Structure#optional

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Apr 1, 2024 that may be closed by this pull request
2 tasks
@Didayolo
Copy link
Member

Didayolo commented Apr 3, 2024

Rebased develop to include CircleCI fix

@Didayolo
Copy link
Member

Didayolo commented Apr 3, 2024

@bbearce @ihsaan-ullah After commenting the "partners" part, the CircleCI tests are passing more frequently but still sometimes they fail

@Didayolo
Copy link
Member

Nice feature!

@Didayolo Didayolo merged commit 2423eb8 into develop Apr 12, 2024
@Didayolo Didayolo deleted the detailed_results branch April 12, 2024 09:44
Didayolo added a commit that referenced this pull request Apr 12, 2024
* organization oidc login added

* unused test file removed

* http client

* some changes

* oidc login and signup added

* oidc flow completed

* Prevent LimitOverrunError with large output lines

If a submission writes a output line larger than the stream buffer
size ( default 64k ) a LimitOverrunError will be raise. Rather than
using readline(...) use readutil(....) and in the case of a overrun
just return the current buffer, the rest of the line will be returned
with the next read.

Signed-off-by: Chris Harris <cjh@lbl.gov>

* terms and condition check added

* one terms checkbox for all organization login buttons

* removed sandbox property from iframe to allow links in the iframe

* Detailed results title removed

* Detailed results configuration (#1374)

* competition model updated

* competition settings to allow participant to make submission public/private

* unwanted restriction removed

* detailed results now shown in submission panel and in leaderboard

* submission tests updated

---------

Signed-off-by: Chris Harris <cjh@lbl.gov>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Chris Harris <chris.harris@kitware.com>
Didayolo added a commit that referenced this pull request Dec 20, 2024
* Merge develop into master (#1405)

* organization oidc login added

* unused test file removed

* http client

* some changes

* oidc login and signup added

* oidc flow completed

* Prevent LimitOverrunError with large output lines

If a submission writes a output line larger than the stream buffer
size ( default 64k ) a LimitOverrunError will be raise. Rather than
using readline(...) use readutil(....) and in the case of a overrun
just return the current buffer, the rest of the line will be returned
with the next read.

Signed-off-by: Chris Harris <cjh@lbl.gov>

* terms and condition check added

* one terms checkbox for all organization login buttons

* removed sandbox property from iframe to allow links in the iframe

* Detailed results title removed

* Detailed results configuration (#1374)

* competition model updated

* competition settings to allow participant to make submission public/private

* unwanted restriction removed

* detailed results now shown in submission panel and in leaderboard

* submission tests updated

---------

Signed-off-by: Chris Harris <cjh@lbl.gov>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Chris Harris <chris.harris@kitware.com>

* Revert "Merge develop into master (#1405)"

This reverts commit a26fc36.

* More general exception in views.py (#1512)

* More general exception in views.py

* Update views.py

* Update version.json for release 1.15.0

---------

Signed-off-by: Chris Harris <cjh@lbl.gov>
Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>
Co-authored-by: Ihsan Ullah <ihsanullah@Pixel-io.local>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Benjamin Bearce <bbearce@gmail.com>
Co-authored-by: Chris Harris <chris.harris@kitware.com>
Co-authored-by: Nicolas Homberg <nicomy_68@hotmail.fr>
Co-authored-by: GitHub Actions <actions@github.com>
Didayolo added a commit that referenced this pull request Jan 16, 2025
* Update version.json for release 1.15.0 (#1712)

* Merge develop into master (#1405)

* organization oidc login added

* unused test file removed

* http client

* some changes

* oidc login and signup added

* oidc flow completed

* Prevent LimitOverrunError with large output lines

If a submission writes a output line larger than the stream buffer
size ( default 64k ) a LimitOverrunError will be raise. Rather than
using readline(...) use readutil(....) and in the case of a overrun
just return the current buffer, the rest of the line will be returned
with the next read.

Signed-off-by: Chris Harris <cjh@lbl.gov>

* terms and condition check added

* one terms checkbox for all organization login buttons

* removed sandbox property from iframe to allow links in the iframe

* Detailed results title removed

* Detailed results configuration (#1374)

* competition model updated

* competition settings to allow participant to make submission public/private

* unwanted restriction removed

* detailed results now shown in submission panel and in leaderboard

* submission tests updated

---------

Signed-off-by: Chris Harris <cjh@lbl.gov>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Chris Harris <chris.harris@kitware.com>

* Revert "Merge develop into master (#1405)"

This reverts commit a26fc36.

* More general exception in views.py (#1512)

* More general exception in views.py

* Update views.py

* Update version.json for release 1.15.0

---------

Signed-off-by: Chris Harris <cjh@lbl.gov>
Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>
Co-authored-by: Ihsan Ullah <ihsanullah@Pixel-io.local>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Benjamin Bearce <bbearce@gmail.com>
Co-authored-by: Chris Harris <chris.harris@kitware.com>
Co-authored-by: Nicolas Homberg <nicomy_68@hotmail.fr>
Co-authored-by: GitHub Actions <actions@github.com>

* Feature/remove user/soft removal (#1691) (#1716)

* add soft deletions attributes in profile class + override deletion method + update email and log in mechanism

* add emails template + soft delete + account view + deletion confirmation view

* move the notice emails in the delete method of user

* filter deleted users out of the front page stat

* disable the action buttons on the list of participants modal in the competition management view

Co-authored-by: Tristan Mary <tristanmary2@gmail.com>

* Updated the filters to show the new "Is Deleted" (#1717)

* Updated the filters to show the new "Is Deleted"

* Flake8 fixes

---------

Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>

* .gitingore update to ignore the home page counters file. Also removed the file from cache so that it's not tracked anymore

* Fix/remove user/soft removal (#1724)

* Set is_active to False when deleting a user

* change the email sending method and populate the missing txt files

* add a checkbox to show/hide deleted users in the list of participant modal

* Fixed the wrong user being named in the greetings in the email sent to admins upon account deletion

* Flake8 fixed

* restricted the usage of deletion link more than one time, used a different deletion token to expire it after deletion, account deletion modal now disappears after clickin the delete my account button

---------

Co-authored-by: OhMaley <tristanmary2@gmail.com>
Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>

* Fix URLs in user deletion email (#1729)

* Fix URLs in user deletion email

* Fix domain

---------

Signed-off-by: Chris Harris <cjh@lbl.gov>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ihsan Ullah <ihsanullah@Pixel-io.local>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Benjamin Bearce <bbearce@gmail.com>
Co-authored-by: Chris Harris <chris.harris@kitware.com>
Co-authored-by: Nicolas Homberg <nicomy_68@hotmail.fr>
Co-authored-by: GitHub Actions <actions@github.com>
Co-authored-by: Tristan Mary <tristanmary2@gmail.com>
Co-authored-by: Obada Haddad-Soussac <11889208+ObadaS@users.noreply.github.com>
Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detailed results

3 participants