Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Apr 11, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

It was not possible to click links in the VISUALIZATION tab of a submission because of an iframe property sandbox. Now this property is removed to allow clicking links.

Issues this PR resolves

A checklist for hand testing

  • In the detailed result file write a link e.g. html_file.write("<p><a href='https://www.google.com/' target='_blank'>Click this link</a></p>")
  • Test that you should NOT be able to click the link (without these changes)
  • Test that you should be able to click the link (with these changes)

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Apr 11, 2024 that may be closed by this pull request
@Didayolo
Copy link
Member

@ihsaan-ullah Can we ask Fair Universe people about how the security threat is problematic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detailed results links

3 participants