Limit over run output #1404
Merged
Limit over run output #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a submission writes a output line larger than the stream buffer size ( default 64k ) a LimitOverrunError will be raise. Rather than using readline(...) use readutil(....) and in the case of a overrun just return the current buffer, the rest of the line will be returned with the next read. Signed-off-by: Chris Harris <cjh@lbl.gov>
Prevent LimitOverrunError with large output lines
7 tasks
Collaborator
Author
Tested@cjh1 Thanks a lot for the change. when you don't have this change and you print the following in your ingestion or scoring program, your submission will be stuck in more_than_64k = "a" * 64000 + "BREAK_POINT" + "b" * 6000
print(more_than_64k)With this change from Chris compute worker will not crash and will return prints normally. |
Member
|
Note for myself: need to update the compute worker docker image for testing and deployment. |
Member
|
Updating all compute workers is needed to take this change into account. Are you using your own queue of compute workers?
|
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #1351 from Chris
@ mention of reviewers
@ihsaan-ullah
A brief description of the purpose of the changes contained in this PR.
If a submission writes a output line larger than the stream buffer size ( default 64k ) a LimitOverrunError will be raise. Rather than using readline(...) use readutil(....) and in the case of a overrun just return the current buffer, the rest of the line will be returned with the next read.
A checklist for hand testing
Checklist