Skip to content

Conversation

@Didayolo
Copy link
Member

@Didayolo Didayolo commented May 23, 2024

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo linked an issue May 23, 2024 that may be closed by this pull request
@Didayolo
Copy link
Member Author

@KamalDas492 Do you know why do we have both a txt file and a html file for each email template?

@Didayolo
Copy link
Member Author

I'm going to deploy and test this on https://codabench-test.lri.fr/

@Didayolo Didayolo merged commit e7fb7bc into develop May 23, 2024
@Didayolo Didayolo deleted the email-enhancement branch May 23, 2024 09:51
@Didayolo
Copy link
Member Author

@KamalDas492

In base_email.html:

  • I don't think the email should START with the logo
  • It seems that the "We're thrilled to inform you that your application [...]" part is directly in base_email.html? Is that normal?

@KamalDas492
Copy link
Contributor

Yes, the part "we're thrilled.." shouldn't be there. It was to be removed. Do you have any other suggestions regarding the styles that you want me to add, since you have suggested not to use the logo?

@Didayolo
Copy link
Member Author

I just put the logo at the end of the email, and removed the "we're thrilled" part. I think it is good like this, I'm testing it on the test server right now.

This was referenced May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise email text

3 participants