Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jul 12, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Previously Pending and Denied participants were able to see leaderboard and then see detailed results page.

NOW only approved participants can see leaderboard and detailed result

Screenshots

Leaderboard:

approved participants will see
approved

pending participants will see
pending

denied participants will see
denied

Detailed result

approved participants will see
approved_result

pending participants will see
Screenshot 2024-07-12 at 1 15 52 PM

denied participants will see
Screenshot 2024-07-12 at 1 16 13 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo changed the title show leaderboard and detailed result page to approved participants show leaderboard and detailed result page to approved participants only Jul 12, 2024
@Didayolo Didayolo self-assigned this Jul 12, 2024
@Didayolo
Copy link
Member

@ihsaan-ullah When the user is neither "Pending" or "Denied", there is no message on the leaderboard:

Capture d’écran 2024-07-17 à 19 07 11

@ihsaan-ullah
Copy link
Collaborator Author

Not a participant (status == null)
Screenshot 2024-07-18 at 10 44 37 AM

Pending participant
Screenshot 2024-07-18 at 10 45 34 AM

Denied participant
Screenshot 2024-07-18 at 10 46 14 AM

Approved participant
Screenshot 2024-07-18 at 10 46 50 AM

@Didayolo Didayolo merged commit da12bd8 into develop Jul 18, 2024
@Didayolo Didayolo deleted the detailed_results branch July 18, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detailed results are visible in leaderboard for participants who are in pending for approval

3 participants