Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Oct 13, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

submissions panel and leaderboard now show submission time in local time zone

Submission panel shows time in local time zone
Screenshot 2024-10-13 at 3 59 46 PM

Leaderboard shows time in local time zone
Screenshot 2024-10-13 at 3 59 36 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Oct 13, 2024 that may be closed by this pull request
@Didayolo
Copy link
Member

Didayolo commented Nov 18, 2024

The date of submission shown is alwayw "2024-10-13 13:00".

On submission_time branch:`

Capture d’écran 2024-11-18 à 15 48 27

On develop branch:

Capture d’écran 2024-11-18 à 15 51 58

@ihsaan-ullah The problem comes from this function:

        self.pretty_date = function (date_string) {
            date_string = "2024-10-13T11:00:00Z"
            if (!!date_string) {
                return luxon.DateTime.fromISO(date_string).toFormat('yyyy-MM-dd HH:mm')
            } else {
                return ''
            }
        }

@Didayolo Didayolo self-assigned this Nov 18, 2024
@Didayolo Didayolo merged commit 101c335 into develop Nov 18, 2024
@Didayolo Didayolo deleted the submission_time branch November 18, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Submission time shown in UTC

3 participants