Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Feb 5, 2025

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

We have now added restrictions for users that are not logged-in and non-participants to not have access to the forum. Non participants cannot create threads/posts in the forum anymore

Screenshots

Not logged-in user view
Screenshot 2025-02-05 at 9 50 54 AM

Participant view
Screenshot 2025-02-05 at 9 52 10 AM

Non-participant view
Screenshot 2025-02-05 at 9 52 30 AM

Issues this PR resolves

A checklist for hand testing

  • Try to access a forum of a competition when you are not logged-in (Should see warning message)
  • Try to access a forum of a competition when you are a participant of the competition. Make sure that you can Add thread/post, delete your post/thread
  • Try to access a forum of a competition when you are NOT a participant (Should see warning message)

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Feb 5, 2025

@ihsaan-ullah

  • As competition participant (or even as a competition organizer), I am able to see the thread list, but I get the yellow warning when trying to create a new topic

  • When hitting a yellow warning, there is no Go back to competition button

@ihsaan-ullah
Copy link
Collaborator Author

@ihsaan-ullah

  • As competition participant (or even as a competition organizer), I am able to see the thread list, but I get the yellow warning when trying to create a new topic
  • When hitting a yellow warning, there is no Go back to competition button

Both problems are fixed
Screenshot 2025-02-06 at 12 01 28 PM

@Didayolo
Copy link
Member

Didayolo commented Feb 6, 2025

Added the "Go back" button for the case the user is not logged in. Should be all good now.

@Didayolo Didayolo merged commit 5b19237 into develop Feb 6, 2025
1 check passed
@Didayolo Didayolo deleted the competition_forum branch February 6, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is there a way to show text (download links) only to users registered to the competition?

3 participants