Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Feb 13, 2025

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

  • Now featured competitions will be shown at the top of the popular competitions list
  • Style added to featured competitions
  • Featured comps section renamed to Recent comps
  • Queries updated for both popular and recent comps
  • Popular and Featured comps are excluded from Recent comps
Screenshot 2025-02-13 at 12 59 02 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Feb 13, 2025 that may be closed by this pull request
2 tasks
@Didayolo Didayolo self-assigned this Feb 13, 2025
@Didayolo Didayolo mentioned this pull request Feb 13, 2025
2 tasks
@Didayolo
Copy link
Member

Didayolo commented Feb 13, 2025

That looks awesome, great job!

I can see that the recent benchmarks are sorted by '-created_when', but for some reason I don't have the most recent public challenges there.

Does not the last line simply return random benchmarks?

return random.sample(list(competitions), limit)

It is fine to have some randomness but it may be fully random here

@Didayolo
Copy link
Member

I'm on it.

@Didayolo Didayolo merged commit 44c7d7f into develop Feb 13, 2025
1 check passed
@Didayolo Didayolo deleted the home_page_competitions branch February 13, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home page competitions

3 participants