Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Feb 19, 2025

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

In the resource interface, there were some problems in the pagination when a task was created or updated. This PR has fixed those problems:

  • On task update, now user will stay on the same page e.g. (page: 3)
  • On task create or upload, user will go to the first page (page: 1)

Issues this PR resolves

A checklist for hand testing

  • upload task when you are not on the first page and see that you are taken to page 1 with the correct page mentioned in the pagination area
  • create task when you are not on the first page and see that you are taken to page 1 with the correct page mentioned in the pagination area
  • update a task on any page and see that you stay on the same page

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Feb 19, 2025 that may be closed by this pull request
3 tasks
@Didayolo Didayolo self-assigned this Feb 19, 2025
@Didayolo Didayolo merged commit 367f94a into develop Feb 20, 2025
1 check passed
@Didayolo Didayolo deleted the task_list branch February 20, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task list paging / editing bug

3 participants