Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Mar 5, 2025

@Didayolo @ObadaS

Description

Do not show soft-deleted submissions on leaderboard.

To investigate: how failed submissions are added to leaderboard

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo merged commit 0d4970f into develop Mar 7, 2025
1 check passed
@Didayolo Didayolo deleted the soft_delete_submission_update branch March 7, 2025 21:48
@Didayolo
Copy link
Member

Didayolo commented Mar 7, 2025

@ihsaan-ullah Is this PR sufficient to solve the #1765 issue?

@ihsaan-ullah
Copy link
Collaborator Author

@ihsaan-ullah Is this PR sufficient to solve the #1765 issue?

Yes this PR will not show deleted submissions on the leaderboard but I have to investigate why the deleted submissions are added to the leaderboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to Remove 'n/a' Scores from Leaderboard after Submission Cancel/Delete?

3 participants