Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 15, 2025

@Didayolo

Description

For some reason the end date calendar was locked and users were not able to change the end date. This was happening because of the link between start date and end date calendars.

Now this is fixed and the connection between start date and end date is removed. Additional checks are added to make sure end date is not before the start date.

If end date is before the start date then users will see this error:
Screenshot 2025-05-15 at 2 30 40 PM

Issues this PR resolves

A checklist for hand testing

  • upload theiris_competition_bundle.zip
  • Check that for phase 1 you can select any date in the end date calendar
  • Select end date that is earlier than start date and check that you see an error when you click the save button

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue May 15, 2025 that may be closed by this pull request
@Didayolo Didayolo self-assigned this May 15, 2025
@Didayolo Didayolo merged commit 4d99dc7 into develop May 15, 2025
1 check passed
@Didayolo Didayolo deleted the end_date branch May 15, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird bug regarding setting up a phase (certain dates are locked)

3 participants