Skip to content

Conversation

@curious-broccoli
Copy link
Contributor

tabs and spaces were mixed, which (depending on the editor settings?) would indent differently.

even better would be to do something like docker run --rm -v ./Caddyfile:/etc/caddy/Caddyfile -it caddy:2.8.4 caddy fmt /etc/caddy/Caddyfile --overwrite before commiting

@Didayolo Didayolo changed the base branch from develop to format-caddyfile May 27, 2025 12:46
@Didayolo Didayolo merged commit 450b70a into codalab:format-caddyfile May 27, 2025
@Didayolo Didayolo mentioned this pull request May 27, 2025
5 tasks
@Didayolo
Copy link
Member

Hi @curious-broccoli,

Thank you for the contribution.

Why is the docker run --rm command required here? Can you explain a bit more? Thanks!

@curious-broccoli
Copy link
Contributor Author

curious-broccoli commented May 27, 2025

not required. it would be a (manual) pre commit formatting step you can run during development after you worked on the Caddyfile to make caddy format it and it will change the mounted Caddyfile

  1. change something in Caddyfile in your feature branch
  2. run the docker command to format the Caddyfile consistently
  3. commit changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants