-
Notifications
You must be signed in to change notification settings - Fork 45
Fixed MC image version and bumped MinIO version #1964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CircleCI test: =================================== FAILURES ===================================
_______________ TestTasks.test_task_shown_as_validated_properly ________________
self = <api.tests.test_tasks.TestTasks testMethod=test_task_shown_as_validated_properly>
def test_task_shown_as_validated_properly(self):
user = UserFactory(username='test')
solution = SolutionFactory(md5="12345")
task = TaskFactory(created_by=user, solutions=[solution])
competition = CompetitionFactory(created_by=user)
phase = PhaseFactory(competition=competition, tasks=[task])
submission = SubmissionFactory(md5="12345", phase=phase, status=Submission.FINISHED)
url = reverse('task-detail', kwargs={'pk': task.id})
self.client.login(username=user.username, password='test')
# task should be validated because we have a successful submission matching
# our solution
resp = self.client.get(url)
assert resp.status_code == 200
> assert resp.data["validated"]
E AssertionError: assert False
src/apps/api/tests/test_tasks.py:25: AssertionErrorOh I guess it is related to: But then how did the tests pass in |
|
The patch that was made didn't pass the test |
Rebase fixedMCversion
|
Now I have this error when trying to run locally codabench-minio-1 | INFO: WARNING: MINIO_ACCESS_KEY and MINIO_SECRET_KEY are deprecated.
codabench-minio-1 | Please use MINIO_ROOT_USER and MINIO_ROOT_PASSWORD
codabench-minio-1 | FATAL Unable to use the drive /export: drive not found: Invalid arguments specifiedProblem 1 - WARNINGChange the variable names to follow recent MinIO versions. I think we need to update:
Problem 2 - FATALUnable to use the drive /export: drive not found: Invalid arguments specifiedI don't know the reason for this, but when I revert the changes of this PR then it works again. |
|
@ObadaS What do you think about this? I may try it locally (or something similar) LLM-proposed solutionFrom me:Answer:That Step-by-step migration (same machine)1) Bring up a fresh MinIO (2025) with a NEW empty data dirAdd a second service (different ports + different volume) to your services:
minio_new:
image: minio/minio:RELEASE.2025-04-22T22-12-26Z
command: server /data
environment:
MINIO_ROOT_USER: newroot
MINIO_ROOT_PASSWORD: newroot-very-strong-pass
volumes:
- ./var/minio-new:/data # <— brand-new empty folder
ports:
- "9100:9000" # S3 API
- "9101:9001" # Web consoleKeep your old MinIO (2020) running on its original volume Important: do not point the 2025 container at your old 2) Set up mc aliases# If you have mc installed locally:
mc alias set old http://localhost:9000 OLDACCESS OLDSECRET
mc alias set new http://localhost:9100 newroot newroot-very-strong-pass
# Sanity check
mc ls old
mc ls new(Replace 3) Mirror buckets (copy everything)You can mirror all buckets in one go with the trailing slashes: # First pass: bulk copy (no live following)
mc mirror --overwrite --preserve --watch=false old/ new/If you want near-zero downtime, run a short “follow” phase while your apps are still writing to the old server: # Optional: keep syncing changes until cutover
mc mirror --overwrite --preserve --watch old/ new/
# (Leave it running for a bit; CTRL+C when you’re ready to cut over)4) Cut over
mc mirror --overwrite --preserve --watch=false old/ new/
What gets copied vs. what does not
Common pitfalls to avoid
|
|
Note: if we don't have safe update instructions, we'll need to revert this PR, as we won't be able to upgrade the servers. |
|
I think 'mc mirror' might be the only option we have, I read some other comments on it that says the same : minio/minio#15967. Here is the official guide to migrate from the old FS to the new one. I think we are migrating FS not Gateway, so users should be choosing the FS migration steps when following the guide |
A brief description of the purpose of the changes contained in this PR.
As recommended here #1957 , I locked down the version of the MC image and updated the MinIO image at the same time
Issues this PR resolves
#1957
Checklist