Skip to content

Conversation

@bbearce
Copy link
Collaborator

@bbearce bbearce commented Aug 31, 2022

Content Type Update For Detailed Results HTML Files

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Detailed results html files weren't showing in the VISUALIZATION tab when viewing a submission's results.

The content-type of the html file was being saved as "binary/octet-stream". This link will retrieve the detailed_results.html if you search it in the URL search in a browser as this content-type allows for that. The link to the minio location is embedded in the html in an iframe on the VISUALIZATION tab however and this causes the html to not be rendered.

A checklist for hand testing

  • Upload IRIS (warning the old IRIS has a yaml bug in the scoring program requiring you to add yaml.Loader as an argument) or Hello World or any challenge that has the scoring program generate *.html detailed results files.
  • Make submission
  • Check the VISUALIZATION tab for results

image

Any relevant files for testing

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • Ready to merge

@Didayolo Didayolo self-assigned this Aug 31, 2022
@Didayolo Didayolo self-requested a review August 31, 2022 13:22
@Didayolo Didayolo merged commit 12db363 into develop Sep 28, 2022
@bbearce bbearce deleted the detailed_results_not_showing branch October 2, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants