Skip to content

tristans suggestion to clean up FF bug #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Didayolo merged 1 commit into from
Oct 6, 2022
Merged

tristans suggestion to clean up FF bug #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/static/riot/competitions/detail/submission_manager.tag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<tr show="{!loading}" each="{ submission, index in filter_children(submissions) }"
onclick="{ submission_clicked.bind(this, submission) }" class="submission_row">
<td if="{opts.admin}">
<div class="ui checkbox" onclick="{submission_checked.bind(this)}">
<div class="ui checkbox" onclick="{on_submission_checked.bind(this)}">
<input type="checkbox" name="{submission.id}">
<label></label>
</div>
Expand Down Expand Up @@ -399,12 +399,12 @@
}
}

self.on_submission_checked = function(event){
event.stopPropagation()
self.submission_checked()
}

self.submission_checked = function () {
if (typeof(event) === "object" ){
// We can't stop upon page load as there is no "event" (button click).
// We can when we we check the checkboxes as that is an "event".
event.stopPropagation()
}
let inputs = $(self.refs.submission_table).find('input')
let checked_boxes = inputs.not(':first').filter('input:checked')
let unchecked_boxes = inputs.not(':first').filter('input:not(:checked)')
Expand Down