Issue 733 - Manual comp creation now will save leaderboard

[bbearce]

@ mention of reviewers

@Didayolo
@Tthomas63

A brief description of the purpose of the changes contained in this PR.

Upon manual UI challenge creation, the leaderboard isn't saved.

Issues this PR resolves

733 (#733)

Known issues to be addressed in a separate PR

N/A

A checklist for hand testing

• Make a challenge using the form in the UI and don't forget to create a leaderboard.
• Next once competition is created, go to edit and make sure the leaderboard you created still exists.
• Also go to results tab and make sure you can see the leaderboard.

Any relevant files for testing

N/A

Misc. comments

I'm worried that this fix and the underlying code I copied or updating a challenge is not what the original creators wanted. See this comment above the code I copied:

codabench/src/apps/api/views/competitions.py

Line 148 in 73cacee

# TODO - This is Temporary. Need to change Leaderboard to Phase connect to M2M and handle this correctly.

.

Checklist

• Code review by me
• Hand tested by me
• I'm proud of my work
• Code review by reviewer
• Hand tested by reviewer
• Ready to merge

[Didayolo]

@bbearce good job
This solves half the issue if I understand correctly?

[bbearce]

Well at first yes but really there are two issues. (1) is the leaderboard which is fixed and the other (2) was the queue. I broke those into two separate issues with the first being this one and the second here #740.