new feature: email confirmation #751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

@ mention of reviewers
@tristan
@Didayolo
A brief description of the purpose of the changes contained in this PR.
There was no email confirmation and we don't want spam accounts to build up quickly.
Issues this PR resolves
#738
Known issues to be addressed in a separate PR
...
A checklist for hand testing
Test error case:
Any relevant files for testing
...
Misc. comments
I'm a little worried I unnecessarily added django "messages" (https://docs.djangoproject.com/en/4.1/ref/contrib/messages/) to the base.html template when I could up setup messages based on API calls (already how things are setup). The problem was I couldn't find how to catch the return response from the signup API call, which is where most messaging functionality happens. We didn't have messages setup as the code was using a javascript package called "toastr" to flash messages. I was able to use django messages (which is nice as we can use them now in the future) and wrap them in toastr so we can get the cool flashes that pop up and everything looks consistent. This is my only worry as far as implementing this correctly.
Checklist