Skip to content

Conversation

@bbearce
Copy link
Collaborator

@bbearce bbearce commented Mar 15, 2023

@ mention of reviewers

@Didayolo
Anne-Catherine

A brief description of the purpose of the changes contained in this PR.

Do not delete the user if the activation link fails to validate. Instead, flash a message saying "Activation link is invalid. Please double check your link."

Issues this PR resolves

(#759)

Known issues to be addressed in a separate PR

...

A checklist for hand testing

  • sign up
  • click activation link in email.
  • you should be able to sign up.

Any relevant files for testing

...

Misc. comments

In case of error due to activation link, you will not be deleted, but rather you will be "inactive". Admins should be able to go into django admin interface and set you to "active".

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Mar 15, 2023

@bbearce

I think you left comments in the file (pdb). Also, the automatic tests seem to be failing.

EDIT: the auto-test failing is a flake8 formatting problem, actually related to the comments:

^@^@src/apps/profiles/views.py:115:13: E265 block comment should start with '# '
src/apps/profiles/views.py:116:13: E265 block comment should start with '# '
src/apps/profiles/views.py:117:13: E265 block comment should start with '# '

So I fixed "both" problems by removing the useless comments.

@Didayolo Didayolo merged commit 6cb33a8 into develop Mar 15, 2023
@Didayolo Didayolo deleted the do_not_delete_user_if_validation_fails branch March 15, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants