Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Apr 4, 2023

@Didayolo @bbearce

Description of changes

Added functionality to view detailed results of a submission

Resolving this issue: #776

Steps to check the changes

  1. Go to Edit Competition and check "Enable Visualizations" checkbox

Screenshot 2023-04-04 at 6 10 42 PM

  1. Go to the Results tab, A new column in the results table "Detailed Results" is added

  2. Click "Show detailed results" to view the detailed results of a submission

Checklist

  • Code review by me
  • Hand tested by me
  • Code review by reviewers
  • Hand tested by reviewer
  • Ready to merge

@Didayolo Didayolo self-requested a review April 4, 2023 16:14
@Didayolo Didayolo self-assigned this Apr 4, 2023
@Didayolo
Copy link
Member

Didayolo commented Apr 4, 2023

When deploying, collectstatic is needed

@Didayolo
Copy link
Member

Didayolo commented Apr 5, 2023

@bbearce @ihsaan-ullah

Maybe the E2E test is failing because the interface never loads:

src/tests/functional/test_submissions.py:74: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
src/tests/functional/test_submissions.py:51: in _run_submission_and_add_to_leaderboard
    assert self.find_text_in_class('.submission_output', expected_submission_output, timeout=timeout)
src/tests/utils.py:130: in find_text_in_class
    return wait.until(EC.text_to_be_present_in_element((By.CSS_SELECTOR, klass), text))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

@Didayolo Didayolo merged commit 9325e3f into develop Apr 5, 2023
@Didayolo Didayolo deleted the submission_detailed_results branch April 5, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants