Skip to content

Change default docker image to py37 #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Didayolo merged 1 commit into from
Apr 19, 2023
Merged

Change default docker image to py37 #807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compute_worker/compute_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ async def _run_program_directory(self, program_dir, kind, can_be_output=False):
# Input from submission (or submission + ingestion combo)
engine_cmd += ['-v', f'{self._get_host_path(self.input_dir)}:/app/input']

# Set the image name (i.e. "codalab/codalab-legacy") for the container
# Set the image name (i.e. "codalab/codalab-legacy:py37") for the container
engine_cmd += [self.container_image]

# Handle Legacy competitions by replacing anything in the run command
Expand Down
2 changes: 1 addition & 1 deletion src/apps/competitions/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class Competition(ChaHubSaveMixin, models.Model):
terms = models.TextField(null=True, blank=True)
is_migrating = models.BooleanField(default=False)
description = models.TextField(null=True, blank=True)
docker_image = models.CharField(max_length=128, default="codalab/codalab-legacy:py3")
docker_image = models.CharField(max_length=128, default="codalab/codalab-legacy:py37")
enable_detailed_results = models.BooleanField(default=False)

queue = models.ForeignKey('queues.Queue', on_delete=models.SET_NULL, null=True, blank=True,
Expand Down
2 changes: 1 addition & 1 deletion src/apps/competitions/tests/unpacker_test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"title": "Sample time series competition",
"description": "Sample competition for time series prediction",
"image": "logo.jpg",
"competition_docker_image": "codalab/codalab-legacy:py3",
"competition_docker_image": "codalab/codalab-legacy:py37",
"end_date": None,
"html": {
"data": "data.txt",
Expand Down
2 changes: 1 addition & 1 deletion src/apps/competitions/unpackers/v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def __init__(self, *args, **kwargs):
# Just in case docker image is blank (""), replace with default value
docker_image = self.competition_yaml.get('competition_docker_image')
if not docker_image:
docker_image = "codalab/codalab-legacy:py3"
docker_image = "codalab/codalab-legacy:py37"

self.competition = {
"title": self.competition_yaml.get('title'),
Expand Down
2 changes: 1 addition & 1 deletion src/apps/competitions/unpackers/v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def __init__(self, *args, **kwargs):
"title": self.competition_yaml.get('title'),
"logo": None,
"registration_auto_approve": self.competition_yaml.get('registration_auto_approve', False),
"docker_image": self.competition_yaml.get('docker_image', 'codalab/codalab-legacy:py3'),
"docker_image": self.competition_yaml.get('docker_image', 'codalab/codalab-legacy:py37'),
"enable_detailed_results": self.competition_yaml.get('enable_detailed_results', False),
"description": self.competition_yaml.get("description", ""),
"competition_type": self.competition_yaml.get("competition_type", "competition"),
Expand Down