Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Apr 21, 2023

@ mention of reviewers

@Didayolo @bbearce @dtuantran

A brief description of the purpose of the changes contained in this PR.

Custom 404 page addded

Screenshot

Screenshot 2023-04-21 at 3 44 12 PM

A checklist for hand testing

  • use any invalid URL to check e.g. https://www.codabench.org/aaa/

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Fixing #700

@Didayolo
Copy link
Member

Didayolo commented Apr 21, 2023

@ihsaan-ullah Thank you very much for taking care of this!

  • I have changed the "return home" URL from codabench.org to /, to avoid local instances and other deployments of the platform to return to the production instance

  • I have fixed flake8 formatting

  • I removed the changes in src/urls.py. What was the purpose of it? It just created a string variable, not using it:

from django.conf.urls import handler404
handler404 = "pages.views.page_not_found_view"

@Didayolo Didayolo merged commit fa2132a into develop Apr 21, 2023
@Didayolo Didayolo deleted the 404_styled branch April 21, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants