Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Apr 22, 2023

@ mention of reviewers

@Didayolo @bbearce @dtuantran

A brief description of the purpose of the changes contained in this PR.

Now users can only use a username which has at least 5 characters and at most 15 characters

Issues this PR resolves

Limits username length

Screenshots

Less than 5 characters
Screenshot 2023-04-22 at 5 42 49 PM

More than 15 characters
Screenshot 2023-04-22 at 5 43 25 PM

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo merged commit cf34d4a into develop Apr 24, 2023
@Didayolo Didayolo deleted the username_limit branch April 24, 2023 11:21
@Didayolo
Copy link
Member

Merged! Thank you @ihsaan-ullah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants