empty profile page fixed, edit profile github url fixed #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice PR, tested and approved. |
Member
|
The E2E tests was passing and now we have this error: # The leaderboard table lists our submission
> prediction_score = Submission.objects.get(pk=submission_id).scores.first().score
E AttributeError: 'NoneType' object has no attribute 'score'Maybe this is just random failures that still need to be addressed. |
Collaborator
Author
|
Weird stuff. Maybe a rerun will fix the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ mention of reviewers
@Didayolo @bbearce
A brief description of the purpose of the changes contained in this PR.
Empty profile page when new user account is created looked weird. Edit profile github URL was mixing with Twitter URL as described in Issue 684
Now users can see placeholders when profile is not updated:
Checklist