Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 4, 2023

@ mention of reviewers

@Didayolo @bbearce

A brief description of the purpose of the changes contained in this PR.

In leaderboard scores are rounded to precision decimal points. precision can be provided in the yaml file as below

leaderboards:
  - index: 0 
    title: Results
    key: main
    submission_rule: "Force_Last"
    columns:
      - index: 0
        title: average auc
        key: auc
        sorting: desc
        precision: 3
      - index: 1
        title: average bac
        key: bac
        sorting: desc
        precision: 4

Issues this PR resolves

  • Solved the long decimal number for scores in leaderboard
  • Precision can be updated in the editor
  • Documentation updated for precision
  • V1 unpacker updated to take into account numeric_format
  • V1 packer tested on V1 Iris bundle

Screenshot of solved problem

Leaderboard
image
image

Editor
image

V1 Unpacking numeric_format into precision
YAML with numeric format
image

Converted numeric to precision as shown in the editor
image

A checklist for hand testing

  • run docker-compose exec django ./manage.py migrate
  • run docker-compose exec django ./manage.py collectstatic --noinput
  • hard refresh (MAC: Command + Shift + R)

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo self-assigned this May 4, 2023
@Didayolo Didayolo self-requested a review May 4, 2023 12:53
@Didayolo Didayolo merged commit 732698d into develop May 4, 2023
@Didayolo Didayolo deleted the leaderboard_decimal_precision branch May 4, 2023 14:44
@Didayolo
Copy link
Member

Didayolo commented May 4, 2023

Hurray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants