Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 4, 2023

@ mention of reviewers

@Didayolo @bbearce

A brief description of the purpose of the changes contained in this PR.

Now users are blocked from submitting to

  1. ENDED phases
  2. NOT STARTED phases

A warning message in red is shown to users when phase has ended
Screenshot 2023-05-04 at 4 19 53 PM

A warning message in yellow is shown to users when phas has not started
Screenshot 2023-05-04 at 4 20 27 PM

Separate error messages are shown in both cases
Screenshot 2023-05-04 at 4 21 43 PM
Screenshot 2023-05-04 at 4 21 52 PM

Issues this PR resolves

blocks user from submitting to ended phases

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah changed the title allow submissions for NOT ENDED phases only allow submissions for NOT ENDED and STARTED phases only May 4, 2023
@Didayolo
Copy link
Member

Didayolo commented May 4, 2023

The tests are failing for a good reason: the competition.zip and competition_18.zip, used in the e2e tests, have already passed deadlines in their competition.yaml. These bundles can be found here:

https://github.com/codalab/codabench/tree/develop/src/tests/functional/test_files

The final phase should be updated to "never ending".

@Didayolo
Copy link
Member

Didayolo commented May 4, 2023

@ihsaan-ullah

I think there is a problem for never ending phase, it is considered closed:

Capture d’écran 2023-05-04 à 17 02 06

@ihsaan-ullah ihsaan-ullah changed the title allow submissions for NOT ENDED and STARTED phases only allow submissions for STARTED and NOT ENDED phases only May 4, 2023
@Didayolo
Copy link
Member

Didayolo commented May 4, 2023

@ihsaan-ullah
This is perfect. I like that the box are red and oranges. I merge it now.

@Didayolo Didayolo merged commit fb4484a into develop May 4, 2023
@Didayolo Didayolo deleted the allow_submissions_during_deadline branch May 4, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants