Skip to content

Open detailed results in new tab #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Didayolo merged 1 commit into from
May 4, 2023
Merged

Open detailed results in new tab #837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/static/riot/competitions/detail/leaderboards.tag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<td if="{submission.organization === null}"><a href="{submission.slug_url}">{ submission.owner }</a></td>
<td if="{submission.organization !== null}"><a href="{submission.organization.url}">{ submission.organization.name }</a></td>
<td each="{ column in filtered_columns }">{ get_score(column, submission) } </td>
<td if="{enable_detailed_results}"><a href="detailed_results/{submission.id}">Show detailed results</a></td>
<td if="{enable_detailed_results}"><a href="detailed_results/{submission.id}" target="_blank">Show detailed results</a></td>
</tr>
</tbody>
</table>
Expand Down Expand Up @@ -121,8 +121,6 @@
CODALAB.api.get_leaderboard_for_render(self.phase_id)
.done(responseData => {
self.selected_leaderboard = responseData


self.columns = []
// Make fake task and columns for Metadata so it can be filtered like columns
if(self.selected_leaderboard.fact_sheet_keys){
Expand Down