Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 5, 2023

@ mention of reviewers

@Didayolo @bbearce

A brief description of the purpose of the changes contained in this PR.

Searchbar of Codabench was showing private competitions of other users

Now if user is not loggedin, only published competitions will be shown
if user is logged in then only public competitions from other users and all his competitions (public/private) will be shown

Unpublished iris is not shown
Screenshot 2023-05-05 at 2 42 35 PM

Published Classify weeds.. is shown
Screenshot 2023-05-05 at 2 58 04 PM

Issues this PR resolves

Issue 705

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented May 9, 2023

This works perfectly. Thank you again for your efforts.

@Didayolo Didayolo merged commit ffb865d into develop May 9, 2023
@Didayolo Didayolo deleted the search_competitions branch May 9, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants