Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 5, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Previosuly if a user was not loggedin, a competition URL with valid secret key was giving 500 error.
Screenshot 2023-05-05 at 4 55 31 PM

Now user can view the competition if he is not loggedin but the secret key is valid. User still has to login in order to participate in the competition

Issues this PR resolves

Issue 842

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo merged commit 59bba41 into develop May 9, 2023
@Didayolo Didayolo deleted the access_competition_private_key branch May 9, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants