Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 9, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

While unpacking V1 bundle, label of column was not used as title in Leaderboard.

Now, with the changes made, the following will happen:

  1. V1 bundle has label for column: label is used as title. Example below:
Screenshot 2023-05-09 at 10 21 02 PM Screenshot 2023-05-09 at 10 21 08 PM
  1. V1 bundle has no label for column: key is used as title. Example below:
Screenshot 2023-05-09 at 10 22 31 PM Screenshot 2023-05-09 at 10 22 16 PM

Issues this PR resolves

#375 point 1

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah mentioned this pull request May 9, 2023
3 tasks
@Didayolo
Copy link
Member

Didayolo commented May 9, 2023

Thank you for re-doing this PR. I've tested it and it works fine.

@Didayolo Didayolo merged commit babe9d4 into develop May 9, 2023
@Didayolo Didayolo deleted the leaderboard_v1_column_label branch May 9, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants