Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 12, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Additional GUI features for leaderboard are implemented

  • Entries
  • Date of last entry

Issues this PR resolves

#375

Screenshots

Screenshot 2023-05-12 at 2 34 51 PM

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

self.update_leaderboard = () => {
CODALAB.api.get_leaderboard_for_render(self.phase_id)
.done(responseData => {
console.log(responseData)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it on purpose that you left this console call?

@Didayolo Didayolo mentioned this pull request May 12, 2023
3 tasks
@Didayolo
Copy link
Member

@ihsaan-ullah I think only the date should be included, without the exact time. This way the interface will be lighter, and it is not necessary to give that level of precision for the time.

@Didayolo
Copy link
Member

@ihsaan-ullah Thank you for the quick update! I'll test this PR soon.

@Didayolo
Copy link
Member

When fact sheets are enabled, the interface looks like this (at least before making a submission):

Capture d’écran 2023-05-12 à 13 50 42

@Didayolo
Copy link
Member

Didayolo commented May 12, 2023

I confirm that "fact sheets answer" is not in the right place, here it should be above "method name":

Capture d’écran 2023-05-12 à 13 54 01

Also the number of entries is wrong, here I made only 1 submission. It seems that the "entries" column show the total number of entries of the user on all platform, not just on the current competition.

@ihsaan-ullah
Copy link
Collaborator Author

Now Entries = all submissions of this user for this phase of competition

This user submitted one submission
Screenshot 2023-05-12 at 6 28 44 PM

Entries = 1
Screenshot 2023-05-12 at 6 29 36 PM

Now factsheet answers will not disturb the UI
Screenshot 2023-05-12 at 6 30 10 PM

@Didayolo
Copy link
Member

Great job! I'm going to test it now.

@Didayolo
Copy link
Member

Perfect! Thanks for the corrections.

@Didayolo Didayolo merged commit d8424b8 into develop May 12, 2023
@Didayolo Didayolo deleted the leaderboard_gui_features branch May 12, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants