Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 27, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now users can see :

  • Actual file name if available in the table
  • Competition name to which this submissions belongs
  • Actual file name in the dataset detail title
  • Competition name is a clickable link to the competition page

In Resources -> Datasets
Screenshot 2023-05-27 at 6 31 52 PM

In Resources -> Datasets -> Detail
Screenshot 2023-05-27 at 4 07 54 PM

Note for old submissions:

  1. Competition name will be empty
  2. File name will be dataset name instead of new actual file name for both table and dataset detail title

Issues this PR resolves

#713 -> Interface -> Point 2,3,4

Submission details: in which benchmark
make benchmark name clickable link
Submission: name it using the filename

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah mentioned this pull request May 27, 2023
42 tasks
@ihsaan-ullah ihsaan-ullah changed the title Show competition name in Resources -> Datasets Show competition name and file name in Resources -> Datasets May 27, 2023
@Didayolo
Copy link
Member

Didayolo commented May 27, 2023

Very nice change!

I guess, as for the job status page (#744), it would be even better if benchmark names were clickable links that open the benchmark in a new tab.

EDIT: See #897

I'll test this asap.

@ihsaan-ullah
Copy link
Collaborator Author

@Didayolo now it should be ok

@Didayolo
Copy link
Member

@ihsaan-ullah Oh I was pushing the same change right now!

@Didayolo
Copy link
Member

So I'll discard my change and pull yours (it is the same anyway).

@Didayolo
Copy link
Member

Didayolo commented May 27, 2023

Some problems with this:

  • The name given when uploading a dataset is not shown anymore:
Capture d’écran 2023-05-27 à 15 50 42
  • When a dataset or a program is in use in a competition task, we see the tag "In use" but "Competition In" is empty:
Capture d’écran 2023-05-27 à 15 52 19

I think this is related to the need to separate the submissions and the datasets (data and programs) in different tabs (see #713). Because this change is great for submissions but not for datasets.


@ihsaan-ullah
Copy link
Collaborator Author

Yes, these conflicts will be solved when datasets and submissions are separated. We are in good direction

@Didayolo Didayolo merged commit 4727824 into develop May 27, 2023
@Didayolo Didayolo deleted the resource_interface_submission_benchmark branch May 27, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants