Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 28, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Main goal of this PR is to add separate tab for submissions and some small additional stuff

  • Added separate tab for submissions
Screenshot 2023-05-28 at 3 09 41 PM
  • Submissions removed from Datasets and programs tab
Screenshot 2023-05-28 at 3 10 05 PM
  • Competition in removed from Datasets and programs
  • Title entered used in Datasets and programs
  • Actual file name used only in submissions tab
  • Filter for type removed from Submissions tab
  • Add Dataset/Program -> Type submission removed from dropdown list of types
  • Add/upload new submission modal added
  • Dataset detail: Benchmark id changed to benchmark name
  • Tasks tab: Benchmark names are now clickable links

Issues this PR resolves

#713 -> Interface -> Point 6

Have a separate tab for submissions

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah mentioned this pull request May 28, 2023
42 tasks
@Didayolo
Copy link
Member

Very nice PR, that was efficient. I'll test it in depth as there are many changes.

@Didayolo
Copy link
Member

Didayolo commented May 30, 2023

This was already like this, but the benchmarks could be clickable URL in the "Task" tab too:

Capture d’écran 2023-05-30 à 13 22 55

In a similar way, the benchmarks in the details when clicking on a dataset could be using the title of the benchmark instead of the ID:

Capture d’écran 2023-05-30 à 13 28 59

Anyway, I've tested the PR and everything seems fine!

@ihsaan-ullah
Copy link
Collaborator Author

Used by Benchmark id is now fixed:
Screenshot 2023-05-30 at 5 03 38 PM

Benchmark as a link in tasks needs more investigation

@ihsaan-ullah
Copy link
Collaborator Author

Screenshot 2023-05-30 at 5 50 26 PM

Benchmarks in tasks table is now a clickable link

@Didayolo
Copy link
Member

Perfect, thank you for the quick edit.

@Didayolo Didayolo merged commit 07aeb0a into develop May 30, 2023
@Didayolo Didayolo deleted the resource_interface_separate_submissions branch May 30, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants