Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jun 1, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

In resource interface, now there is an option to show/hide public submissions/datasets and programs

Submissions (without public)
Screenshot 2023-06-01 at 3 45 39 PM

Submissions (with public)
Screenshot 2023-06-01 at 3 45 45 PM

Datasets and programs (without public)
Screenshot 2023-06-01 at 3 45 51 PM

Datasets and programs (with public)
Screenshot 2023-06-01 at 3 46 01 PM

What is done in this PR

  • add option in submissions tab to show/hide public submissions
  • add option in datasets/programs to show/hide public datasets/programs
  • custom filters added in /datasets api to filter submission/datasets with public filter
  • hide delete button from submissions which are from other users
  • hide selection checkbox from submissions which are from other users

Issues this PR resolves

#713 -> Resource interface -> Points : 7, 8

Public datasets should have their own tab
Public datasets should not have delete button if they do not belong to us

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo mentioned this pull request Jun 1, 2023
42 tasks
@Didayolo
Copy link
Member

Didayolo commented Jun 1, 2023

@ihsaan-ullah Thank you for the PR.

You mentionned this item:

Public datasets should not have delete button if they do not belong to us

But I see that the red buttons are still there for public submissions/datasets. Also, it seems that the delete buttons are not working anymore.

@ihsaan-ullah
Copy link
Collaborator Author

@Didayolo

working on the hiding of delete buttion.
I have checked and delete functionality is working as expected.

The PR is not finalized yet. It will be ready in an hour

@Didayolo
Copy link
Member

Didayolo commented Jun 1, 2023

OK thank you for the feedback. No pressure.

@ihsaan-ullah
Copy link
Collaborator Author

ihsaan-ullah commented Jun 1, 2023

Delete buttons and checkboxes are now visible for my submissions and datasets/programs only

Screenshot 2023-06-01 at 4 14 59 PM Screenshot 2023-06-01 at 4 15 19 PM

@Didayolo
Copy link
Member

Didayolo commented Jun 1, 2023

Nice work as always

@Didayolo Didayolo merged commit f631cfa into develop Jun 1, 2023
@Didayolo Didayolo deleted the resource_interface_public_submissions_datasets branch June 1, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants